Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] Fix interference between ContextMenus on measurements and Canvas #1462

Merged
merged 1 commit into from
Apr 22, 2024
Merged

[FIX] Fix interference between ContextMenus on measurements and Canvas #1462

merged 1 commit into from
Apr 22, 2024

Conversation

xeolabs
Copy link
Member

@xeolabs xeolabs commented Apr 22, 2024 •
edited
Loading

This PR addresses #1461

  • Create this example that demonstrates how to have context menus on measurements AND canvas, such that there is not interference between the right-click input used to open each menu.
  • Ensure that events are properly consumed by measurement HTML elements.

@xeolabs xeolabs added this to the 2.6.0 milestone Apr 22, 2024
@xeolabs xeolabs changed the title [FIX] Fix interference between ContextMenus on measurements and Canvas #1461 [FIX] Fix interference between ContextMenus on measurements and Canvas Apr 22, 2024
@xeolabs xeolabs merged commit 954490e into master Apr 22, 2024
3 of 4 checks passed
@xeolabs
Copy link
Member Author

xeolabs commented Apr 22, 2024

Fixed in xeokit-sdk 2.6.3: https://github.com/xeokit/xeokit-sdk/releases/tag/v2.6.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.6.0
Development

Successfully merging this pull request may close these issues.
1 participant
@xeolabs